Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN Prices should be formatted for the locale of the page #13476

Closed
pmac opened this issue Aug 1, 2023 · 1 comment
Closed

VPN Prices should be formatted for the locale of the page #13476

pmac opened this issue Aug 1, 2023 · 1 comment
Assignees
Labels
Backend Server stuff yo Bug 🐛 Something's not working the way it should

Comments

@pmac
Copy link
Member

pmac commented Aug 1, 2023

We're currently getting this almost right, but in some cases the format of the number and symbol (e.g. 4.99 € vs €4,99) vary quite a bit for different locales. As part of this we should move to letting Fluent handle this kind of formatting.

FluentNumber is a class in the Fluent system that can format number input for a particular locale and currency. It would be nice if we could build in handling for currency formatting into the ftl() helper in bedrock for use in templates.

@pmac pmac added Bug 🐛 Something's not working the way it should Backend Server stuff yo labels Aug 1, 2023
alexgibson added a commit to alexgibson/bedrock that referenced this issue Aug 2, 2023
alexgibson added a commit to alexgibson/bedrock that referenced this issue Aug 2, 2023
@alexgibson
Copy link
Member

I opened a PR linked above for the short term fix that updates Euro formatting for en locales.

Looking in bedrock, we're already using babel's format_currency helper in some places for the newer Relay code. We could use that for VPN also, however if we want to add currency formatting to the ftl() helper like you suggest, I'll leave that for a back-end dev to take a look at.

alexgibson added a commit to alexgibson/bedrock that referenced this issue Aug 2, 2023
alexgibson added a commit to alexgibson/bedrock that referenced this issue Aug 2, 2023
@alexgibson alexgibson self-assigned this Aug 10, 2023
alexgibson added a commit to alexgibson/bedrock that referenced this issue Aug 11, 2023
alexgibson added a commit to alexgibson/bedrock that referenced this issue Aug 15, 2023
alexgibson added a commit to alexgibson/bedrock that referenced this issue Aug 16, 2023
alexgibson added a commit to alexgibson/bedrock that referenced this issue Aug 16, 2023
alexgibson added a commit to alexgibson/bedrock that referenced this issue Aug 17, 2023
alexgibson added a commit to alexgibson/bedrock that referenced this issue Aug 18, 2023
alexgibson added a commit to alexgibson/bedrock that referenced this issue Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Server stuff yo Bug 🐛 Something's not working the way it should
Projects
None yet
Development

No branches or pull requests

2 participants