Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

…see-how-firefox-for-desktop-stacks wrong number of compared browsers #14354

Closed
janbrasna opened this issue Mar 24, 2024 · 3 comments
Closed
Assignees
Labels
Bug 🐛 Something's not working the way it should

Comments

@janbrasna
Copy link
Contributor

janbrasna commented Mar 24, 2024

Description

At the bottom of the mobile browsers page, there is a box that tells people they can read more about firefox compared to other browsers. The text in the box says:

browsers-mobile-see-how-firefox-for-desktop-stacks = See how { -brand-name-firefox } for desktop stacks up to seven other browsers.

Firefox mobile browsers

"… stacks up to seven other browsers."

The target page lists six browsers total, i. e. five other browsers.

Steps to reproduce

  1. go to https://www.mozilla.org/en-US/firefox/browsers/mobile/
  2. scroll to the bottom and observe

Expected result

browsers-mobile-see-how-firefox-for-desktop-stacks string and localizations contain the correct number of compared UAs.

Actual result

The string (in EN and localizations alike) contains "seven other browsers", while in reality the comparison page shows six browsers total, i. e. it's only five other browsers.

@janbrasna janbrasna added the Bug 🐛 Something's not working the way it should label Mar 24, 2024
@craigcook craigcook self-assigned this Mar 26, 2024
@janbrasna
Copy link
Contributor Author

Ah I see it now, the number of browsers changed most recently for #14142 in #14167 so this string would also need some updating anyways.

What is the best way? Keep the current string as fallback and add a -v2 new saying "five others"? Or to make it easier to maintain try to re-use some of the recently updated strings for comparison? Or maybe separating out the number as a variable and use a number not word for futureproofing? Or maybe omitting the number entirely from the string, leaving it as "see how fx stacks up to other browsers" and be done?

@craigcook
Copy link
Member

I'm updating this string along with other comparison page updates in #14336.

I've gone for your third option, to just omit the number so we won't need to worry about it again.

@janbrasna
Copy link
Contributor Author

Resolved for now via #14426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something's not working the way it should
Projects
None yet
Development

No branches or pull requests

2 participants