Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh: CSS base bundle clean up #15120

Closed
4 tasks done
Tracked by #14826
wen-2018 opened this issue Sep 11, 2024 · 0 comments
Closed
4 tasks done
Tracked by #14826

Refresh: CSS base bundle clean up #15120

wen-2018 opened this issue Sep 11, 2024 · 0 comments
Assignees
Labels
Refresh 🦖 Work related to the 2024 site refresh

Comments

@wen-2018
Copy link
Collaborator

wen-2018 commented Sep 11, 2024

Description

Currently, the m24 base bundle doesn't include existing component styles. We should update it to include common styles in protocol-mozilla, but with imports of the new nav / footer, home and new styles instead of the old ones, avoiding serving redundant styles to users when the brand refresh switch is on:

{% if switch('m24-base') and LANG.startswith('en-') %}
  {{ css_bundle('m24-base') }}
{% else %}
  {{ css_bundle('protocol-mozilla') }}
{% endif %}

Tasks

@wen-2018 wen-2018 added the Refresh 🦖 Work related to the 2024 site refresh label Sep 11, 2024
@wen-2018 wen-2018 mentioned this issue Sep 11, 2024
11 tasks
@stephaniehobson stephaniehobson moved this to Dev Ready in Moz.org Refresh Sep 11, 2024
@stephaniehobson stephaniehobson assigned wen-2018 and unassigned wen-2018 Oct 9, 2024
craigcook added a commit to craigcook/bedrock that referenced this issue Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refresh 🦖 Work related to the 2024 site refresh
Projects
Status: Done
Development

No branches or pull requests

1 participant