Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[m24] Navigation styling breaks when old nav CSS is removed from base bundle #15196

Closed
alexgibson opened this issue Sep 20, 2024 · 0 comments
Closed
Assignees
Labels
Bug 🐛 Something's not working the way it should

Comments

@alexgibson
Copy link
Member

Description

The CSS for the new navigation is overriding the stylesheet for the older navigation, so when we remove the old styles the new styles break:

image

Steps to reproduce

Comment out these two lines: https://github.com/mozilla/bedrock/blob/main/media/css/protocol/protocol-mozilla-2024.scss#L32-L33

Expected result

Both the new navigation and footer should display as expected.

Actual result

The footer seems OK, but the new navigation breaks since it relies on existing styles in the old navigation stylesheet.

Environment

N/A

@alexgibson alexgibson added the Bug 🐛 Something's not working the way it should label Sep 20, 2024
@wen-2018 wen-2018 self-assigned this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something's not working the way it should
Projects
Status: Done
Development

No branches or pull requests

2 participants