Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTM Review] Review "Remove CJS" workspace #15259

Closed
Tracked by #14749
stephaniehobson opened this issue Oct 8, 2024 · 1 comment
Closed
Tracked by #14749

[GTM Review] Review "Remove CJS" workspace #15259

stephaniehobson opened this issue Oct 8, 2024 · 1 comment
Assignees
Labels
Needs Review Awaiting code review

Comments

@stephaniehobson
Copy link
Contributor

stephaniehobson commented Oct 8, 2024

One-line summary

Review and publish GTM workspace "Remove CJS"

Significant changes and points to review

  • remove 2 custom JS filters in favour of directly using attribute values

Issue

Fix #13951
Fix #14054
See also #14749

Supporting bedrock changes:

#14910

Testing

Shouldn't be much to do, GTM prevents deletion of stuff that's still in use. I suppose you could search that data-link-group is gone from the bedrock code? But Reem did a pretty through review of #14910

@alexgibson
Copy link
Member

Approved and published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review
Projects
None yet
Development

No branches or pull requests

2 participants