Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Newsletter complementary landmark should be top level (/about/manifesto/) #15336

Closed
Tracked by #14773
alexgibson opened this issue Oct 21, 2024 · 2 comments · Fixed by #15377
Closed
Tracked by #14773

[a11y] Newsletter complementary landmark should be top level (/about/manifesto/) #15336

alexgibson opened this issue Oct 21, 2024 · 2 comments · Fixed by #15377
Assignees
Labels
a11y Issues related to accessibility Bug 🐛 Something's not working the way it should Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system Help wanted 👋 Community contributions welcome

Comments

@alexgibson
Copy link
Member

Axe-core® Accessibility Results for /en-US/about/manifesto/

Page URL: https://www-dev.allizom.org/en-US/about/manifesto/

axe-core found 1 violation

# Description Axe rule ID WCAG Impact Count
1 Aside should not be contained in another landmark landmark-complementary-is-top-level Best practice moderate 1

Failed

  1. Aside should not be contained in another landmark

Learn more

landmark-complementary-is-top-level

Best practice

Ensure the complementary landmark or aside is at top level

moderate

Issue Tags: cat.semantics best-practice

# Issue Description To solve this violation, you need to...
1 Element location

<br>.mzp-c-newsletter<br>

Element source

<br><aside class="mzp-c-newsletter"><br>
Fix any of the following:

* The null landmark is contained in another landmark.
@alexgibson alexgibson added Bug 🐛 Something's not working the way it should a11y Issues related to accessibility labels Oct 21, 2024
@alexgibson alexgibson added the Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system label Oct 21, 2024
@alexgibson
Copy link
Member Author

alexgibson commented Oct 21, 2024

Tip: a suitable fix for this would be to move the newsletter section of the page out of the top level <main> landmark, so that the <aside> (and its mzp-l-content parent element) come immediately after <main>, instead of being child elements.

@stevejalim stevejalim self-assigned this Oct 21, 2024
@alexgibson alexgibson added the Help wanted 👋 Community contributions welcome label Oct 21, 2024
@clarapenn
Copy link
Contributor

Hi, I'd like to work on this one - thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues related to accessibility Bug 🐛 Something's not working the way it should Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system Help wanted 👋 Community contributions welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants