Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[a11y] /advertising page is missing a main landmark #15337

Closed
Tracked by #14773
alexgibson opened this issue Oct 21, 2024 · 3 comments
Closed
Tracked by #14773

[a11y] /advertising page is missing a main landmark #15337

alexgibson opened this issue Oct 21, 2024 · 3 comments
Assignees
@clarapenn
Labels
a11y Issues related to accessibility Bug 🐛 Something's not working the way it should Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system Help wanted 👋 Community contributions welcome

Comments

@alexgibson
Copy link
Member

Axe-core® Accessibility Results for /en-US/advertising/

Page URL: https://www-dev.allizom.org/en-US/advertising/

axe-core found 5 violations

# Description Axe rule ID WCAG Impact Count
1 Document should have one main landmark landmark-one-main Best practice moderate 1
2 All page content should be contained by landmarks region Best practice moderate 4

Failed

  1. Document should have one main landmark

Learn more

landmark-one-main

Best practice

Ensure the document has a main landmark

moderate

Issue Tags: cat.semantics best-practice

# Issue Description To solve this violation, you need to...
1 Element location

<br>html<br>

Element source

<br><html class="windows js windows-10-plus x64 is-modern-browser mzp-has-sticky-navigation loaded" lang="en" dir="ltr" data-country-code="US" data-needs-consent="False" data-latest-firefox="131.0.3" data-esr-versions="128.3.1" data-gtm-container-id="GTM-MW3R8V" data-stub-attribution-rate="1.0" data-sentry-dsn="https://c1f94ae1b8c54ed0adcf223328157caf@o1069899.ingest.sentry.io/6260211"><br>		 Fix all of the following:

* Document does not have a main landmark
  1. All page content should be contained by landmarks

Learn more

region

Best practice

Ensure all page content is contained by landmarks

moderate

Issue Tags: cat.keyboard best-practice

# Issue Description To solve this violation, you need to...
1 Element location

<br>.mzp-c-callout<br>

Element source

<br><section class="mzp-c-callout mozads-header"><br>		 Fix any of the following:

* Some page content is not contained by landmarks
2 Element location

<br>.mozads-t-dark<br>

Element source

<br><section class="mzp-c-split mozads-t-dark mzp-t-dark mzp-t-content-xl"><br>		 Fix any of the following:

* Some page content is not contained by landmarks
3 Element location

<br>.mzp-l-split-reversed<br>

Element source

<br><section class="mzp-c-split mzp-l-split-reversed mzp-t-content-xl mozads-anonym"><br>		 Fix any of the following:

* Some page content is not contained by landmarks
4 Element location

<br>#outer-wrapper > section:nth-child(4)<br>

Element source

<br><section><br>		 Fix any of the following:

* Some page content is not contained by landmarks
@alexgibson alexgibson added Bug 🐛 Something's not working the way it should a11y Issues related to accessibility labels Oct 21, 2024
@alexgibson alexgibson mentioned this issue Oct 21, 2024
Open
@alexgibson alexgibson added the Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system label Oct 21, 2024
@alexgibson
Copy link
Member Author

Tip: all of the above violations can likely be fixed simply by wrapping the main page content in a <main> element.

@alexgibson alexgibson added the Help wanted 👋 Community contributions welcome label Oct 21, 2024
@clarapenn
Copy link
Contributor

@alexgibson could I be assigned this one, please? Thanks!

@clarapenn clarapenn mentioned this issue Oct 25, 2024
Merged
1 task
@stevejalim
Copy link
Collaborator

Fixed in 2dba421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clarapenn clarapenn

Labels
a11y Issues related to accessibility Bug 🐛 Something's not working the way it should Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system Help wanted 👋 Community contributions welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevejalim @alexgibson @clarapenn