Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] /contribute all page content should be contained in landmarks #15340

Closed
alexgibson opened this issue Oct 21, 2024 · 2 comments · Fixed by #15364
Closed

[a11y] /contribute all page content should be contained in landmarks #15340

alexgibson opened this issue Oct 21, 2024 · 2 comments · Fixed by #15364
Assignees
Labels
a11y Issues related to accessibility Bug 🐛 Something's not working the way it should Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system Help wanted 👋 Community contributions welcome

Comments

@alexgibson
Copy link
Member

Axe-core® Accessibility Results for /en-US/contribute/

Page URL: https://www-dev.allizom.org/en-US/contribute/

axe-core found 6 violations

# Description Axe rule ID WCAG Impact Count
1 All page content should be contained by landmarks region Best practice moderate 6

Failed

  1. All page content should be contained by landmarks

Learn more

region

Best practice

Ensure all page content is contained by landmarks

moderate

Issue Tags: cat.keyboard best-practice

# Issue Description To solve this violation, you need to...
1 Element location

<br>.mzp-c-split<br>

Element source

<br><section class="mzp-c-split mzp-t-split-nospace"><br>
Fix any of the following:

* Some page content is not contained by landmarks
2 Element location

<br>.mzp-c-newsletter-header<br>

Element source

<br><header class="mzp-c-newsletter-header"><br>
Fix any of the following:

* Some page content is not contained by landmarks
3 Element location

<br>label[for="id_email"]<br>

Element source

<br><label for="id_email">Your email address:</label><br>
Fix any of the following:

* Some page content is not contained by landmarks
4 Element location

<br>#id_email<br>

Element source

<br><input type="email" name="email" required="" data-testid="newsletter-email-input" maxlength="320" placeholder="yourname@example.com" class="mzp-js-email-field" id="id_email"><br>
Fix any of the following:

* Some page content is not contained by landmarks
5 Element location

<br>.mzp-c-fieldnote<br>

Element source

<br><span class="mzp-c-fieldnote"><br> <br> <br> We will only send you Mozilla-related information. You can unsubscribe at any time.<br> <br> </span><br>
Fix any of the following:

* Some page content is not contained by landmarks
6 Element location

<br>.contribute-banner-wrapper<br>

Element source

<br><section class="contribute-banner-wrapper"><br>
Fix any of the following:

* Some page content is not contained by landmarks
@alexgibson alexgibson added Bug 🐛 Something's not working the way it should a11y Issues related to accessibility Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system Help wanted 👋 Community contributions welcome labels Oct 21, 2024
@alexgibson
Copy link
Member Author

alexgibson commented Oct 21, 2024

Tip: This can probably be fixed by wrapping the core page content in a <main> element, and then making the last three sections (newsletter, get help, problems with a web page) <aside> landmarks that are siblings of <main> (and not children).

@stevejalim stevejalim self-assigned this Oct 21, 2024
@clarapenn
Copy link
Contributor

@stevejalim 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues related to accessibility Bug 🐛 Something's not working the way it should Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system Help wanted 👋 Community contributions welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants