Direct Win 8.1 / macOs 10.14 users to ESR for FF release channel (Fixes #13317) #13390
Conversation
alexgibson
force-pushed
the
win8-esr-release
branch
from
78504c9
to
34b3222
Compare
alexgibson
added
P1
|
This has got the green light from QA, so is ready for code review: https://docs.google.com/spreadsheets/d/1b9vn-bjYivprwebaXH3-sOM9y-IyB8DET2g7rsaTsRI/edit?usp=sharing |
|
Successful test run: https://github.com/mozilla/bedrock/actions/runs/5576889605 |
| @@ -134,7 +134,7 @@ <h4>{{ ftl('firefox-home-get-trackers-off') }}</h4> | |||
| <div id="test-menu-browsers-wrapper" class="mzp-c-menu-list mzp-t-cta mzp-t-download"> | |||
| <h5 class="mzp-c-menu-list-title">{{ ftl('firefox-home-download-the-browser') }}</h5> | |||
| <ul class="mzp-c-menu-list-list" id="menu-browsers"> | |||
| {# Old IE users need to click a download button, the JS on the thank you page doesn't get them the right download if we send them there directly #} | |||
| {# Direct legacy IE users to the /new/ page where they can read EOL messaging see issue 13317 #} | |||
There was a problem hiding this comment.
If the visitor is on IE 11 they won't see any link for desktop in the drop down menu because they fall in the space between support for the direct link and support for conditional comments (they only go up to IE10).
There was a problem hiding this comment.
I’m not sure I follow. IE11 is on Windows 10/11 only, so should not be effected by these changes. Unless I’m misunderstanding?
There was a problem hiding this comment.
At least, if IE 11 is available for Windows 8, then the expected behaviour would be to not see a desktop download link
There was a problem hiding this comment.
IE 11 is in the list for 8.1 on Browser Stack 🤷♀️
There was a problem hiding this comment.
It looks a little weird to not mention desktop but it's not technically broken:
There was a problem hiding this comment.
Yeah, I don’t think I’m going to spend hours fitting messaging into non-standard places where we’ve chosen to not use download buttons.
There was a problem hiding this comment.
The conditional comment here sends IE6-10 users to the /new page to read the EOL messaging. If you remove the comments and display it contingent on .fx-unsupported we can give that experience to Edge & IE 11 too.
Alternatively, I suggest removing the conditional comment entirely so that the IE6-11 experience is the same.
There was a problem hiding this comment.
Hmm interesting suggestion! I'll take a look here and give it a try :)
There was a problem hiding this comment.
Added a commit to direct all unsupported users from /firefox/ to /new/ - thanks for the suggestion!
There was a problem hiding this comment.
Just commenting since I'm not done testing but I'm going to have to lunch/change locations soon.
There's some placeswhere I think it makes sense to just hide the download button. OTOH it does not make sense to spend more than 15 minutes working on it. @alexgibson if you think it would be quick those places are release notes and all the pages in /browsers
- Win 7 / IE 9
- Win 8 / IE 10
- Win 8.1 / IE 11
- Win 8.1/ Edge 100
- https://www-demo2.allizom.org/en-US/firefox/browsers/windows-64-bit/
- https://www-demo2.allizom.org/en-US/firefox/browsers/windows/
- https://www-demo2.allizom.org/en-US/firefox/new/
- https://www-demo2.allizom.org/en-US/firefox/features/safebrowser/
- https://www-demo2.allizom.org/en-US/firefox/
- https://www-demo2.allizom.org/en-US/firefox/faq
- https://www-demo2.allizom.org/en-US/firefox/sync
- https://www-demo2.allizom.org/en-US//firefox/browsers/browser-history/
- https://www-demo2.allizom.org/en-US/firefox/
- https://www-demo2.allizom.org/en-US/firefox/117.0a1/releasenotes/
- https://www-demo2.allizom.org/en-US/firefox/115.0/releasenotes/
|
Something else I forgot to mention in the description: we’re not applying this change to /all, at least for now |
Yeah, that makes sense, /all has fewer guard rails. |
alexgibson
force-pushed
the
win8-esr-release
branch
from
34b3222
to
15c84d7
Compare
One-line summary
This PR is a followup to #13334, which takes things another step by applying the same messaging to the main Firefox release channel download links.
This needs to be live before August 1st, when FF 116 is released.
Significant changes and points to review
Firefox download buttons appear in many places on the website, so this requires some careful testing.
Issue / Bugzilla link
#13317
Screenshots
Example messaging for Windows 8.1/8/7 users:
Testing
This is up on demo2, and is easiest to test using BrowserStack.
https://www-demo2.allizom.org/en-US/firefox/new/
I compiled a QA checklist for the product team than covers our main download pages: https://docs.google.com/document/d/1TBxUfK7WPB5npGdiRHg6GrAv5K8VEHDcNQQ3Ls0jd5Y/edit?usp=sharing
There are of course, many more pages where a FF download button can appear, so some more expansive testing during review is probably required.