Fix newsletter management page form submission when cookie has expired (Fixes #13324) #13448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgibson
added
P3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Stores token in local memory so that the form still works even if left open for a long period of time.
Significant changes and points to review
Rather than wait for an hour for the cookie to expire, the easiest way to test this is to delete the
nl-tokencookie after the page has loaded, and then hit submit after that.Issue / Bugzilla link
#13324
Testing
First get your token here: https://www.mozilla.org/en-US/newsletter/recovery/
Then open
http://localhost:8000/en-US/newsletter/existing/YOUR_TOKEN_HERE/