Update euro currency formatting for English locales (Issue #13476) #13479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgibson
added
P2
alexgibson
force-pushed
the
vpn-euro-en-formatting
branch
from
df4f19a
to
2a4b0c9
Compare
alexgibson
commented
Aug 2, 2023
| @@ -1011,13 +1011,19 @@ def test_vpn_monthly_price_usd_ca(self): | |||
|
|
|||
| def test_vpn_monthly_price_euro(self): | |||
| """Should return expected markup""" | |||
| markup = self._render(plan="monthly", country_code="DE", lang="de") | |||
| markup = self._render(plan="monthly", country_code="DE", lang="en-US") | |||
There was a problem hiding this comment.
Note for reviewer: updating lang here to match the locale of the request used in the test (en-US) to make things a bit clearer. The lang param is only used for selecting a stripe plan, rather than anything to do with the string translation.
alexgibson
force-pushed
the
vpn-euro-en-formatting
branch
from
2a4b0c9
to
8614ffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
This is only a short term fix for the original issue highlighted in #13476. It does not address adding currency formatting to the
ftl()helper, which will provide a more robust solution.Issue / Bugzilla link
#13476
Testing
http://localhost:8000/en-US/products/vpn/?geo=fi