solved issue # #13492 #13497
solved issue # #13492 #13497
Conversation
There was a problem hiding this comment.
Thanks for the contribution! It needs a few small fixes before we can merge this. And because this is addressing two completely separate issues in a single pull request, it might be better to separate them into two pull requests.
Also, it would be good to amend the commit messages to be more descriptive of what's actually changing. Something like "Update whatsnew page title (fixes #13492)" and "Add update frequency note to Nightly channel page (fixes #9832)"
| @@ -24,6 +24,7 @@ firefox-channel-all-languages-and-builds = All Languages and Builds | |||
| # Variables: | |||
| # $link (url) - link to https://www.mozilla.org/privacy/firefox/#pre-release | |||
| firefox-channel-beta-is-an-unstable-testing = { -brand-name-beta } is an unstable testing and development platform. By default, { -brand-name-beta } sends data to { -brand-name-mozilla } — and sometimes our partners — to help us handle problems and try ideas. <a href="{ $link }">Learn what is shared</a>. | |||
| firefox-channel-beta-update-one-or-more-times = Note: { -brand-name-firefox-nightly } will update approximately one or two times each day. | |||
There was a problem hiding this comment.
To avoid confusion, the string ID here should probably be firefox-channel-nightly-update-one-or-more-times
| firefox-channel-beta-update-one-or-more-times = Note: { -brand-name-firefox-nightly } will update approximately one or two times each day. | |
| firefox-channel-nightly-update-one-or-more-times = Note: { -brand-name-firefox-nightly } will update approximately one or two times each day. |
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| ### URL: https://www-dev.allizom.org/firefox/60.0/whatsnew/ | |||
|
|
|||
| whatsnew-page-title = What’s new with { -brand-name-firefox } - More privacy, more protections. | |||
| whatsnew-page-title = What’s new with { -brand-name-firefox }. | |||
There was a problem hiding this comment.
This needs to be added as a new string with a new ID, leaving the old string to use as a fallback in the template (see our documentation for how to specify a fallback string: https://bedrock.readthedocs.io/en/latest/l10n.html#the-ftl-helper-function).
For the new string ID I'd suggest whatsnew-page-title-v2
There was a problem hiding this comment.
Got it, I'll create a new string with the ID "whatsnew-page-title-v2" and keep the old one as a fallback. I'll make sure to update the commit message accordingly. Thanks for your direction!
|
closing this due to inactivity. If you find time to revisit this issue, please feel free to reopen! |
One-line summary
Significant changes and points to review
Issue / Bugzilla link
Testing