Update leadership page layout #13557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-barrett
added
Needs Review
nathan-barrett
force-pushed
the
13554-leadership-pay-layout
branch
2 times, most recently
from
ef35bfe
to
0bf7dac
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #13557 +/- ##
==========================================
+ Coverage 76.54% 76.62% +0.08%
==========================================
Files 147 147
Lines 7880 7856 -24
==========================================
- Hits 6032 6020 -12
+ Misses 1848 1836 -12
☔ View full report in Codecov by Sentry. |
|
received approval, so this is good to merge once r+ |
craigcook
approved these changes
Aug 15, 2023
| </article> | ||
|
|
||
| </div> | ||
| {% include "mozorg/about/leadership/includes/executive.html"%} |
There was a problem hiding this comment.
Ooo very smart doing these as includes! This could have easily turned into a massive template that would scroll forever.
bedrock/mozorg/redirects.py
Outdated
| @@ -562,4 +562,9 @@ def decider(request, **kwargs): | |||
| redirect(r"^/exp/opt-out/?$", "privacy.convert-opt-out"), | |||
| # Issue 13211 | |||
| redirect(r"^/en/$", "/en-US/", permanent=True), | |||
| # Issue 13554 | |||
| redirect(r"^about/leadership/senior-leadership/$", "/about/leadership#senior/"), | |||
There was a problem hiding this comment.
I think the trailing slash should go before the hash on all of these:
Suggested change
| redirect(r"^about/leadership/senior-leadership/$", "/about/leadership#senior/"), | |
| redirect(r"^about/leadership/senior-leadership/$", "/about/leadership/#senior"), |
nathan-barrett
force-pushed
the
13554-leadership-pay-layout
branch
from
0bf7dac
to
26e7fed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
#13554 - Changes the leadership page organization and layout.
Significant changes and points to review
/about/leadership has changed to include all members on one page - subnavigation has been updated to use anchor links as well
Issue / Bugzilla link
#13554
Testing
http://localhost:8000/en-US/about/leadership