Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN wave VI expansion post-launch cleanup (Fixes #13552) #13580

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

alexgibson
Copy link
Member

One-line summary

Removed switches and conditionals for the now launched VPN expansion work

Significant changes and points to review

Did I miss anything?

Issue / Bugzilla link

#13552

Testing

Wave VI countries should still see VPN pricing e.g.

Wave VI countries should still see the 115 WNP e.g.

Full list of supported countries should be visible:

Supported countries should say 33:

@alexgibson alexgibson added P3 Third level priority - Nice to have Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b206798) 76.62% compared to head (d54c47a) 76.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13580   +/-   ##
=======================================
  Coverage   76.62%   76.63%           
=======================================
  Files         147      147           
  Lines        7856     7849    -7     
=======================================
- Hits         6020     6015    -5     
+ Misses       1836     1834    -2     
Files Changed Coverage Δ
bedrock/products/views.py 67.91% <ø> (+0.43%) ⬆️
bedrock/firefox/views.py 90.21% <100.00%> (-0.22%) ⬇️
bedrock/settings/base.py 94.29% <100.00%> (-0.04%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼

@craigcook craigcook merged commit 2feb0dc into mozilla:main Aug 28, 2023
5 checks passed
@alexgibson alexgibson deleted the vpn-cleanup branch June 17, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review P3 Third level priority - Nice to have Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants