Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove structured json metadata (Fixes #13618) #13669

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

alexgibson
Copy link
Member

One-line summary

Removes structured JSON product metadata from bedrock pages

Issue / Bugzilla link

#13618

Testing

Did I miss anything?

@alexgibson alexgibson added P3 Third level priority - Nice to have Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Sep 13, 2023
@alexgibson
Copy link
Member Author

Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this include can go to:
/bedrock/bedrock/mozorg/templates/mozorg/mpl/2.0/includes/structured-data-faq.html

With the reference in:
/bedrock/bedrock/mozorg/templates/mozorg/mpl/2.0/faq.html

Otherwise looks good R+wc

@stephaniehobson stephaniehobson removed the Needs Review Awaiting code review label Sep 15, 2023
@alexgibson alexgibson merged commit 501f37f into mozilla:main Sep 18, 2023
3 checks passed
@alexgibson alexgibson deleted the remove-json branch September 18, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Third level priority - Nice to have Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants