Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert buttons with data-link-type="download" into CTAs #14955

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Convert buttons with data-link-type="download" into CTAs #14955

merged 2 commits into from
Sep 11, 2024

Conversation

stephaniehobson
Copy link
Contributor

@stephaniehobson stephaniehobson commented Aug 2, 2024 •
edited
Loading

One-line summary

Convert buttons with data-link-type="download" into CTAs.

Significant changes and points to review

  • data-display-name ➡ data-cta-text
  • data-link-location ➡ data-cta-position
  • data-download-os="Desktop|Android|iOS" ➡ data-cta-type="firefox|firefox_mobile|firefox_focus"
  • data-link-type
  • data-download-language
  • data-download-version is used by stub attribution, don't touch

Issue / Bugzilla link

#14062

Testing

  • I did not remove any instances of data-download-version
  • All edited elements have data-cta-text (they won't get tracked if they don't)
  • No data-download-language remains
  • No data-link-type="download" remain

Notes:

@stephaniehobson stephaniehobson changed the title convert to cta Convert buttons with data-link-type="download" into CTAs Aug 2, 2024
@stephaniehobson stephaniehobson force-pushed the ua-downloads branch 3 times, most recently from 5555b74 to 57cada5 Compare August 6, 2024 22:18
@stephaniehobson stephaniehobson force-pushed the ua-downloads branch 2 times, most recently from 5cc5f94 to d9ad0c3 Compare August 20, 2024 23:43
@stephaniehobson stephaniehobson force-pushed the ua-downloads branch 4 times, most recently from 52e1f8f to 6a3347f Compare August 22, 2024 16:32
@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (8ff4c3d) to head (ee1dfd0).
Report is 27 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14955      +/-   ##
==========================================
- Coverage   77.85%   77.84%   -0.02%     
==========================================
  Files         162      162              
  Lines        8450     8464      +14     
==========================================
+ Hits         6579     6589      +10     
- Misses       1871     1875       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephaniehobson stephaniehobson force-pushed the ua-downloads branch 2 times, most recently from 6bf2c1b to eb159b9 Compare August 22, 2024 17:06
@stephaniehobson stephaniehobson marked this pull request as ready for review August 22, 2024 17:09
@stephaniehobson stephaniehobson added P3 Third level priority - Nice to have Needs Review Awaiting code review Review: S Code review time: 30 mins to 1 hour P2 Second level priority - Should have and removed P3 Third level priority - Nice to have labels Aug 22, 2024
@stephaniehobson stephaniehobson added the Frontend HTML, CSS, JS... client side stuff label Aug 30, 2024
@stephaniehobson stephaniehobson added P1 First level priority - Must have and removed P2 Second level priority - Should have labels Sep 9, 2024
@reemhamz reemhamz self-assigned this Sep 9, 2024
reemhamz
reemhamz approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@reemhamz reemhamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of tiny things to answer/add. But I also think it'd be a good idea to update our docs to recommend these new changes rather than the old data attributes. Great job with this! r+wc 🦖

bedrock/firefox/templates/firefox/browsers/chromebook.html Outdated Show resolved Hide resolved
bedrock/firefox/templates/firefox/browsers/mobile/index.html Outdated Show resolved Hide resolved
@stephaniehobson
Copy link
Contributor Author

@reemhamz doc updates are in #14910 :)

@reemhamz reemhamz removed the Needs Review Awaiting code review label Sep 11, 2024
@stephaniehobson stephaniehobson merged commit 6657abd into main Sep 11, 2024
5 checks passed
@stephaniehobson stephaniehobson deleted the ua-downloads branch September 11, 2024 17:13
@stephaniehobson stephaniehobson mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reemhamz reemhamz reemhamz approved these changes

Assignees

@reemhamz reemhamz

Labels
Analytics 📈 Frontend HTML, CSS, JS... client side stuff P1 First level priority - Must have Review: S Code review time: 30 mins to 1 hour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephaniehobson @reemhamz