Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Firefox 20th landing page image, fix text misalignment issue #15466

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

wen-2018
Copy link
Collaborator

@wen-2018 wen-2018 commented Nov 7, 2024

One-line summary

This PR updates the Firefox 20th landing page image with a new one that fixed the mis-aligned text

Significant changes and points to review

Issue / Bugzilla link

#15383

Testing

http://localhost:8000/en-US/firefox/firefox20/

@craigcook craigcook self-assigned this Nov 7, 2024
Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running this file through tinypng should save another 20k or so. r+wc

Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, a minor nitpick: I'd recommend a more descriptive commit message. You could mention which page this is for and what problem this fixes.

@wen-2018 wen-2018 changed the title image fix update Firefox landing page image, fix text misalignment issue Nov 7, 2024
@wen-2018 wen-2018 changed the title update Firefox landing page image, fix text misalignment issue update Firefox 20th landing page image, fix text misalignment issue Nov 7, 2024
@craigcook craigcook merged commit fba0e13 into mozilla:main Nov 7, 2024
3 checks passed
@wen-2018 wen-2018 deleted the firefox20-image-fix branch November 7, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants