Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Union default_table_workgroup_access with table-level workgroup_access in metadata generation logic #5830

Open
whd opened this issue Jun 24, 2024 · 0 comments

Comments

@whd
Copy link
Member

whd commented Jun 24, 2024

When we implemented retention metadata support via default_table_workgroup_access, we introduced a gotcha where unless you specify the value of default_table_workgroup_access explicitly in a table's manually created workgroup_access, access to that table will be restricted to just the manual grants if there are deprecated tables in the same dataset.

80dc786 is an example of this: if there were deprecations in mozilla_org_derived, give the way our metadata generation currently works, workgroup:mozilla-confidential would have lost access to the table.

We should for non-deprecated tables automatically apply default_table_workgroup_access to the table-level metadata.yaml workgroup_access, and probably have a CI/lint check to warn against the redundant specification in both places once this is implemented.

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant