Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mozlint diffs #31

Open
La0 opened this issue May 28, 2019 · 1 comment · May be fixed by #437
Open

Support mozlint diffs #31

La0 opened this issue May 28, 2019 · 1 comment · May be fixed by #437
Assignees
@La0
Labels
bot Code review bot enhancement New feature or request

Comments

@La0
Copy link
Collaborator

La0 commented May 28, 2019

Since Bug 1552897, mozlint supports diff outputs, and so issues spanning over multiple lines.

The bot needs to support that to publish valid formatting issues (aka rustfmt).

Example on this try job where no rustfmt were reported
@La0 La0 self-assigned this May 28, 2019
La0 referenced this issue in La0/mozilla-relengapi May 28, 2019
staticanalysis/bot: Support mozlint diffs, fixes #2139.
f6400c5
@La0 La0 changed the title Support mozlint diffs WIP Support mozlint diffs May 28, 2019
@La0 La0 changed the title WIP Support mozlint diffs Support mozlint diffs May 28, 2019
La0 referenced this issue in La0/mozilla-relengapi Jun 4, 2019
staticanalysis/bot: Support mozlint diffs, fixes #2139.
3796e21
@La0 La0 transferred this issue from mozilla/release-services Jun 11, 2019
@La0 La0 added bot Code review bot enhancement New feature or request labels Jun 11, 2019
@La0
Copy link
Collaborator Author

La0 commented Jun 11, 2019

This PR mozilla/release-services#2140 needs to be imported & converted to the new repo.

La0 pushed a commit that referenced this issue Jun 12, 2019
bot: Support mozlint patches for rustfmt, fixes #31.
d4e89cd
@La0 La0 mentioned this issue Jun 12, 2019
Closed
La0 pushed a commit to La0/code-review that referenced this issue Jul 23, 2019
bot: Support mozlint patches for rustfmt, fixes mozilla#31.
91bc6d0
@La0 La0 mentioned this issue Jan 13, 2020
Closed
La0 pushed a commit to La0/code-review that referenced this issue Jan 14, 2020
bot: Support mozlint diffs, fixes mozilla#31
af06d1d
@La0 La0 linked a pull request Jan 14, 2020 that will close this issue
Open
La0 pushed a commit to La0/code-review that referenced this issue Feb 18, 2020
bot: Support mozlint diffs, fixes mozilla#31
0845149
La0 pushed a commit to La0/code-review that referenced this issue Feb 24, 2020
bot: Support mozlint diffs, fixes mozilla#31
e679e49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@La0 La0

Labels
bot Code review bot enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support mozlint diffs La0/code-review
Support mozlint diff mozilla/code-review
1 participant
@La0