Add submodules for tier-1 rust backends. #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://github.com/mozilla/cubeb/wiki/Backend-Support the rust backends for pulse and coreaudio are tier-1 and the older C++ backends are tier-4. So, add these backends to cubeb by default.
|
cc @padenot for a review :) |
|
302 @kinetiknz, who last looked at maybe merging those (iirc?). |
|
Hi @kinetiknz , any chance of taking a look here? :) |
|
I'll eventually merge the repositories, since it's a pain to make ABI-breaking changes (among other things) with the current structure. This is a good first step though, so let's merge it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://github.com/mozilla/cubeb/wiki/Backend-Support the rust backends for pulse and coreaudio are tier-1 and the older C++ backends are tier-4. So, add these backends to cubeb by default.
I can also set BUILD_RUST_LIBS to ON by default in this PR, but I'm not sure if there's some reason to avoid doing that.