Skip to content

Commit

Permalink
Add suffix _date to name of datetime metrics (#1655)
Browse files Browse the repository at this point in the history
  • Loading branch information
Iinh authored Apr 4, 2023
1 parent 069a642 commit 9dc3572
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion etl/looker.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def get_looker_explore_metadata_for_metric(
elif metric_type in SUPPORTED_LOOKER_METRIC_TYPES:
base_looker_dimension_name = "{}.{}".format(
ping_name_snakecase, get_bigquery_column_name(metric).replace(".", "__")
)
) + ("_date" if metric_type == "datetime" else "")
# For distribution types, we'll aggregate the sum of all distributions per
# day. In most cases, this isn't super meaningful, but provides a starting
# place for further analysis
Expand Down

0 comments on commit 9dc3572

Please sign in to comment.