Skip to content

Commit

Permalink
Fix quotes in Events dashboard links (#2078)
Browse files Browse the repository at this point in the history
* Fix quotes in Events dashboard links

* Use event_category and name for identifying events
  • Loading branch information
scholtzan authored Jan 24, 2024
1 parent 2fe20f6 commit c688e7d
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions etl/looker.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,10 +273,11 @@ def get_looker_monitoring_metadata_for_event(app, app_group, metric, ping_name):
if metric_type != "event":
return None

(_, metric_name) = get_event_name_and_category(metric.identifier)
(metric_category, metric_name) = get_event_name_and_category(metric.identifier)
event_identifier = ".".join([metric_category, metric_name])

url = furl(EVENT_MONITORING_DASHBOARD_URL).add(
{"App Name": app.app["canonical_app_name"], "Event Name": metric_name}
{"App Name": app.app["canonical_app_name"], "Event Name": '"' + event_identifier + '"'}
)

app_channel = app.app.get("app_channel")
Expand Down

0 comments on commit c688e7d

Please sign in to comment.