Skip to content

Commit

Permalink
[Bug 1886159] Use improved click events from Glean (#2159)
Browse files Browse the repository at this point in the history
* Updated package @mozilla/glean to 5.0.0-pre.0
* Remove "pointer-events:none" instrumentation for nested elements
* Ran formatter and linter
  • Loading branch information
abhi-agg authored Mar 22, 2024
1 parent a6caeb6 commit fc07df1
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 22 deletions.
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@babel/plugin-transform-runtime": "7.23.9",
"@babel/preset-env": "^7.23.9",
"@mozilla-protocol/core": "^17.0.1",
"@mozilla/glean": "^4.1.0-pre.0",
"@mozilla/glean": "^5.0.0-pre.0",
"@playwright/test": "^1.41.2",
"@rollup/plugin-commonjs": "25.0.7",
"@rollup/plugin-node-resolve": "15.2.3",
Expand Down
16 changes: 2 additions & 14 deletions src/pages/AppList.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -86,15 +86,7 @@
id="media-block"
data-glean-label="Home page: {app.app_name}"
>
<div
class="mzp-c-card-media-wrapper"
id="media-wrapper"
style="pointer-events:none"
>
<!-- Setting style attribute is required above to allow capturing clicks on all nested elements
via Glean. Once https://bugzilla.mozilla.org/show_bug.cgi?id=1885504 is fixed it can be removed
from div tag above.
-->
<div class="mzp-c-card-media-wrapper" id="media-wrapper">
<img
class="mzp-c-card-imgage"
src={app.logo || "/img/app-logos/mozilla.png"}
Expand All @@ -110,11 +102,7 @@
/>
{/if}
</div>
<div class="mzp-c-card-content" style="pointer-events:none">
<!-- Setting style attribute is required above to allow capturing clicks on all nested elements
via Glean. Once https://bugzilla.mozilla.org/show_bug.cgi?id=1885504 is fixed it can be removed
from div tag above.
-->
<div class="mzp-c-card-content">
<h2 class="mzp-c-card-title">{app.canonical_app_name}</h2>
{#if app.deprecated}
<Label text="deprecated" />
Expand Down

0 comments on commit fc07df1

Please sign in to comment.