Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to metrics in Data Catalog #1881

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Link to metrics in Data Catalog #1881

merged 1 commit into from
Apr 18, 2024

Conversation

Iinh
Copy link
Contributor

@Iinh Iinh commented Aug 31, 2023 •
edited
Loading

Link to metrics now that column-level lineage is available in Data Catalog.

Pull Request checklist

  • The pull request has a descriptive title (and a reference to an issue it
    fixes, if applicable)
  • All tests and linter checks are passing
  • The pull request is free of merge conflicts

@Iinh Iinh force-pushed the data-catalog-metrics branch 2 times, most recently from 56f46e1 to 20ba49c Compare August 31, 2023 13:13
@Iinh Iinh requested a review from ANich August 31, 2023 14:06
@Dexterp37
Copy link
Contributor

@Iinh is this something we still want? Do you want me to help poking people?

@Iinh
Copy link
Contributor Author

Iinh commented Nov 14, 2023

@Iinh is this something we still want? Do you want me to help poking people?

Yes we still want this, but tabling this work for now due to a UI issue in Data Catalog that prevents metric column from being shown. Will pick it back up once that is fixed.

@Dexterp37
Copy link
Contributor

@Iinh is this something we still want? Do you want me to help poking people?

Yes we still want this, but tabling this work for now due to a UI issue in Data Catalog that prevents metric column from being shown. Will pick it back up once that is fixed.

Hey @Iinh , was the blocker fixed? If not, would you please block this against the ticket used to track the other problem?

@Iinh Iinh marked this pull request as ready for review April 17, 2024 18:51
@Iinh
Copy link
Contributor Author

Iinh commented Apr 17, 2024

thanks @Dexterp37!

@ANich could you review this and see if it's good to go - thank you!

ANich
ANich approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@ANich ANich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions/thoughts. In the preview I'm not really seeing much though I only looked at a few examples

src/state/urls.js Show resolved Hide resolved
@Iinh Iinh force-pushed the data-catalog-metrics branch 3 times, most recently from f1d37e3 to 8ca3769 Compare April 18, 2024 21:36
@Iinh Iinh merged commit 6709c9f into main Apr 18, 2024
8 checks passed
@Iinh Iinh deleted the data-catalog-metrics branch April 18, 2024 22:50
@Dexterp37
Copy link
Contributor

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ANich ANich ANich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Iinh @Dexterp37 @ANich