[Bug 1883593] Instrumentation to capture more clicks via glean #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- An empty string causes glean's data attributes to be present in Consumers that don't pass these props, causing clicks to be recorded in them - As per https://svelte.dev/docs/basic-markup#attributes-and-props, setting it to "null"
|
@rosahbruno I have added a new instrumentation in the code to capture clicks on links corresponding to Would it be possible for you to give me an early feedback on this instrumentation? I just want to make sure that I am heading in right direction as a lot of instrumentation will follow the same pattern. Thanks. |
rosahbruno
reviewed
Mar 26, 2024
- Capture clicks in "Access" section - Capture clicks on "Sampling Configuration Snippet" inside "Metric sampling" section
- Capture clicks on "Metrics", "Pings", "Tags", "Application IDs" and "Third-Party Data" tabs
|
Okay. I am marking this PR read to review. This PR adds instrumentation to capture clicks on:
I have tested this change locally and it works as expected. |
travis79
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1883593
Pull Request checklist
fixes, if applicable)