Bug 1887694 - Generate events_stream SQL for events #2196
Conversation
| // Although events might come from other pings, we override that and | ||
| // generate SQL just for the `events_stream`. This changes | ||
| // `some_database.table` to `some_database.events_stream`. |
There was a problem hiding this comment.
I'm not really sure if we want to retain the old SQL code generation. Does it make any sense? This is quite a hack @badboy
There was a problem hiding this comment.
For events that are not in an events ping this will be incorrect with this change, because they don't end up in the stream just yet.
But otherwise it's fine; no point in keeping the legacy way around
There was a problem hiding this comment.
Ok, what about this? We retain the old query for non 'events' pings until this gets fixed.
Dexterp37
changed the title
| // Although events might come from other pings, we override that and | ||
| // generate SQL just for the `events_stream`. This changes | ||
| // `some_database.table` to `some_database.events_stream`. |
There was a problem hiding this comment.
For events that are not in an events ping this will be incorrect with this change, because they don't end up in the stream just yet.
But otherwise it's fine; no point in keeping the legacy way around
Fixes #2185
Pull Request checklist
fixes, if applicable)