Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1892726 - Update Server Knobs configuration snippets #2197

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Bug 1892726 - Update Server Knobs configuration snippets #2197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02540fe
Bug 1892726 - Update Server Knobs configuration snippets
travis79 Apr 24, 2024
c146b77
Bug 1892726 - Part 2: Add configuration snippets for pings
travis79 Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/MetricDetail.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@
</td>
<td>
<CopyButton
textToCopy="{'{\n "gleanMetricConfiguration": {\n "'}{metric.name}{'": true\n }\n}'}"
textToCopy="{'{\n "gleanMetricConfiguration": {\n "metrics_enabled": {\n "'}{metric.name}{'": true\n }\n }\n}'}"
type="MetricDetail.MetricSampling.CopySamplingConfigurationSnippet"
/>
</td>
Expand Down
36 changes: 36 additions & 0 deletions src/pages/PingDetail.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import VariantSelector from "../components/VariantSelector.svelte";
import AuthenticatedLink from "../components/AuthenticatedLink.svelte";
import Commentary from "../components/Commentary.svelte";
import CopyButton from "../components/CopyButton.svelte";
import HelpHoverable from "../components/HelpHoverable.svelte";
import ItemList from "../components/ItemList.svelte";
import Label from "../components/Label.svelte";
Expand Down Expand Up @@ -88,6 +89,41 @@
/>
<Commentary item={ping} itemType={"ping"} />

<SubHeading
title={"Server Knobs Configuration"}
helpText={"Information about Server Knobs configuration for this ping."}
/>
<table>
<col />
<col />
<col />
<tr>
<td>
Sampling Configuration Snippet
<HelpHoverable
content={"Click the button to copy a configuration snippet for use in Mozilla Experimenter configuration"}
link={"https://mozilla.github.io/glean/book/user/pings/data-control-plane/experimenter-configuration.html"}
/>
</td>
<td>
Click the button to copy a snippet for use in a
<a
href="https://mozilla.github.io/glean/book/user/pings/data-control-plane/experimenter-configuration.html"
data-glean-label="Mozilla Experimenter configuration"
data-glean-type="PingDetail.PingSampling.MozillaExperimenterConfigurationURL"
>
Mozilla Experimenter configuration.
</a>
</td>
<td>
<CopyButton
textToCopy="{'{\n "gleanMetricConfiguration": {\n "pings_enabled": {\n "'}{ping.name}{'": true\n }\n }\n}'}"
type="PingDetail.PingSampling.CopySamplingConfigurationSnippet"
/>
</td>
</tr>
</table>

<SubHeading
title={"Access"}
helpText={"Ways to access this metric in Mozilla's data warehouse."}
Expand Down