Server crashes on the 32767th connection.

[QUICTester]

There is a hardcoded value in an assertion statement ("target/debug/build/neqo-crypto-a4be3db97961b0ce/out/nspr/pr/src/io/prlayer.c:619") causing the Neqo server only able to accepts up to 32767 connections (including the closed connections). After the 36767th connection, the server will crash with an assertion error. We know that the PRIntn data type used for PRDescIdentity is guaranteed to be 16-bits long. However, the PRIntn data type on our architecture is 32 bits long. Therefore, instead of using a hardcoded value, the assertion statement should use a dynamic value that follows the architecture (reference: https://firefox-source-docs.mozilla.org/nspr/reference/printn.html).

[larseggert]

This is the crash
https://github.com/nss-dev/nspr/blob/dead7133d4535bf4fade1814dd8c261c01b76635/pr/src/io/prlayer.c#L619

Called from

neqo/neqo-crypto/src/agent.rs

Line 329 in 36fae62

let id = unsafe { prio::PR_GetUniqueIdentity(label.as_ptr()) };

[martinthomson]

I'm surprised that we can handle that many connections, but maybe we can tweak NSPR. The 16 bit era is long gone.

[larseggert]

Patch to NSPR in https://bugzilla.mozilla.org/show_bug.cgi?id=1890927