Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ES2015 default values inside destructuring assignments #756

Open
Osiris-Team opened this issue Aug 6, 2020 · 5 comments
Open

Support ES2015 default values inside destructuring assignments #756

Osiris-Team opened this issue Aug 6, 2020 · 5 comments
Labels
Ecma Incompatibility Issues about Rhino being incompatible with the EcmaScript spec feature Issues considered a new feature
Milestone

Comments

@Osiris-Team
Copy link

            // default values inside destructuring assignments,
            // like 'var [a = 10] = b' or 'var {a: b = 10} = c',
            // are not supported
            reportError("msg.destruct.default.vals");
@p-bakker p-bakker changed the title Add support for default values inside destructuring assignments Support ES2015 default values inside destructuring assignments Jun 29, 2021
@p-bakker p-bakker added this to the ES2015 milestone Jun 29, 2021
@Osiris-Team
Copy link
Author

Wow thats great!

@Osiris-Team
Copy link
Author

Seems like just a matter of years now.

@gbrail
Copy link
Collaborator

gbrail commented Aug 30, 2021

@Osiris-Team the fastest way to get that part of the standard implemented into Rhino is to submit a PR. There are a few of us here who are willing and ready to help you with that.

@p-bakker
Copy link
Collaborator

To expand on @gbrail comment: Rhino is an all-volunteer effort and as such hasn't got anyone working on it fulltime.

Cases are picked up based on own need/interest or general desire to move things forward.

We have recently made the effort to at least start creating cases for all the things where Rhino is not compatible with the latest EcmaScript spec and assigning those issues into milestones. But this is more to gain insight and hopefully inspire people to contribute, than a plan to start implementing all these things asap.

So, as @gbrail said: we welcome contributions!

@p-bakker p-bakker added the feature Issues considered a new feature label Oct 14, 2021
@p-bakker p-bakker added the Ecma Incompatibility Issues about Rhino being incompatible with the EcmaScript spec label Jul 30, 2024
This was referenced Sep 22, 2024
@p-bakker
Copy link
Collaborator

#1640 has moved the needle on this one significantly, if not completely resolved it

Waiting on analysis whether there's anything remaining (see #1640 (comment)) before potentially closing this as done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ecma Incompatibility Issues about Rhino being incompatible with the EcmaScript spec feature Issues considered a new feature
Projects
None yet
Development

No branches or pull requests

3 participants