Fix regressions introduced to debugger #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly identify the button being pressed using non-deprecated functions to fix regression introduced earlier.
|
This includes fixes originally contributed to #1367 |
|
Hey @gbrail, thank you for looking into this. I did checkout your branch and did some quick testing and poking around. I can confirm, that the breakpoint-fix still works and I didn't find any other obvious problem. However I wouldn't know where to look for in the context of the |
|
Thanks -- I think I know what that other method does and it seems to be working. I'm going to merge this. Thanks for checking it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates a change made by @jonasPoehler with additional changes to fix debugger regressions introduced earlier.
Could regular users of the debugger please try it out? Some obviously-broken functionality seems to be working again compared
to previous releases but there may be more to test.