Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a missing array limit check #1371

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

rbri
Copy link
Collaborator

@rbri rbri commented Aug 13, 2023

found this while working on the proxy support
see built-ins/Array/prototype/concat/arg-length-exceeding-integer-limit.js

@@ -1656,7 +1660,14 @@ private static Scriptable js_concat(
scope = getTopLevelScope(scope);
final Scriptable result = cx.newArray(scope, 0);

long length = doConcat(cx, scope, result, o, 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be changed here? I verified this in my environment and the test passed with doConcat as well.


/**
* @see <a
* href="https://github.com/mozilla/rhino/issues/673">https://github.com/mozilla/rhino/issues/673</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment correct? It looks to me like the issue not directly related to this Pull Request.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give me a second...

@rbri
Copy link
Collaborator Author

rbri commented Aug 13, 2023

@tuchida (and all the others)
was a bit in a hurry, hope you like the new version ;-)

Copy link
Contributor

@tuchida tuchida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gbrail
Copy link
Collaborator

gbrail commented Aug 16, 2023

Nice fix. Thanks!

@gbrail gbrail merged commit a1e011b into mozilla:master Aug 16, 2023
3 checks passed
@rbri rbri deleted the array_concat_limit branch August 16, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants