-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a missing array limit check #1371
Conversation
@@ -1656,7 +1660,14 @@ private static Scriptable js_concat( | |||
scope = getTopLevelScope(scope); | |||
final Scriptable result = cx.newArray(scope, 0); | |||
|
|||
long length = doConcat(cx, scope, result, o, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be changed here? I verified this in my environment and the test passed with doConcat
as well.
|
||
/** | ||
* @see <a | ||
* href="https://github.com/mozilla/rhino/issues/673">https://github.com/mozilla/rhino/issues/673</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment correct? It looks to me like the issue not directly related to this Pull Request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
give me a second...
86308e2
to
2dad787
Compare
@tuchida (and all the others) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Nice fix. Thanks! |
found this while working on the proxy support
see built-ins/Array/prototype/concat/arg-length-exceeding-integer-limit.js