Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toString() on generator #1462

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Conversation

0xe
Copy link
Contributor

@0xe 0xe commented Apr 4, 2024

toString() on a generator misses the *. This change adds that to the encodedSource.

For example,

  function* f() {
    yield 1;
  }; f.toString();

returns,

Before:

  function f() {
    yield 1;
  }

After:

  function* f() {
    yield 1;
  }

@0xe 0xe force-pushed the scratch/satish/gen.toString branch from af03bf0 to fcc6069 Compare April 4, 2024 07:17
@0xe 0xe force-pushed the scratch/satish/gen.toString branch from fcc6069 to fb31915 Compare April 5, 2024 01:39
@rbri
Copy link
Collaborator

rbri commented Apr 27, 2024

@0xe thanks for your PR

@rbri rbri merged commit 709874b into mozilla:master Apr 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants