Fixed handling of unicode characters in the lexer #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lexer was not handling correctly surrogate pairs. References: - https://tc39.es/ecma262/#prod-IdentifierName - https://en.wikipedia.org/wiki/UTF-16#Code_points_from_U+010000_to_U+10FFFF
|
@andreabergia looks promising, can you please have a look at the failing tests... |
Unfortunately, some of the tests pass only on higher version of the JDK, because they have updated unicode support. On JDK 1.8 we get a lot of failures that we aren't getting on Java 11 or 17.
|
The problem is that the behavior of the Java unicode checks differs depending on the JDK - so the same code might say that a character is a valid unicode identifier on java 11 but not on java 8. Some tests of test262 are failing because of that, it seems. |
|
Thanks a lot @andreabergia, another step forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lexer was not handling correctly surrogate pairs. References: