-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin to use invokedynamic in the bytecode #1645
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbrail
force-pushed
the
indy-9-restart
branch
from
September 24, 2024 06:19
22df4ed
to
54e0386
Compare
Unless there are no objections, I'd like to merge this. Just so that you all understand the scope: Downsides:
Upsides:
|
No objections here! Wrt to the downsides: dunno how feasible it is, but some documentation on the bytecode generation may help? Got the idea that only a few people understand how that works right now. I for one don't at all 🙂 |
Use Dynalink, but only install a dynamic linker for now
Also make the DefaultLinker code have a bit less copy and paste
This feature should never be invoked on Android.
Make sure that the "target" of each operation is always first. For now, at least, do this without changing ScriptRuntime.
rbri
reviewed
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins to use invokedynamic instructions in Rhino's bytecode.
It replaces the operations that call the ScriptRuntime operations for
common property operations like setting and getting properties and
elements, and common context operations like setting and getting variables,
with invokedynamic instructions.
It also adds components that will wire up those invokedynamic instructions
to the appropriate ScriptRuntime operations using the Dynalink package.
The result should be that Rhino behaves exactly the same and performs the
same as well.
However, once this is implemented we can begin to create additional dynalink
"linkers" that do specific things to optimize performance based on what is
happening at runtime.