-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated: Implement Symbol.prototype.description #1651
Conversation
Refactored `NativeSymbol` to use `LambdaConstructor` instead of `IdScriptableObject`.
Fix how LambdaConstructor handles constructor functions.
@@ -2312,25 +2312,15 @@ built-ins/Symbol 36/94 (38.3%) | |||
asyncDispose/prop-desc.js | |||
asyncIterator/prop-desc.js | |||
dispose/prop-desc.js | |||
for/cross-realm.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does the overall count does not change? Have you regenerated the file or just removed the failing tests?
+1 |
Yes, I updated test262.properties manually. I just re-ran the tests with "updateTest262properties=true" and it produced 8000 lines of changes. Maybe I'm doing something wrong? I don't know how to begin to verify whether that's correct. |
Will try it here.... give me 5 min |
use this and you are fine built-ins/Symbol 26/94 (27.66%) |
seems like the head version of the file is already a bit out of sync - will make a pr |
@gbrail test262.properties is updated on head, simple fix by replacing the appropriate line with 'built-ins/Symbol 26/94 (27.66%)' and you are done and ready to merge |
Thanks! I need to work on my real job for a bit but I'll get to it tonight!
|
Have fun with both.... |
Thanks @andreabergia and @gbrail! |
This includes the changes made by @andreabergia to:
Since so many things have changed in this area recently, and since the lambda
implementation wasn't totally ready for this, and since I wanted this to
use Lambdas appropriately AND move forward, this PR includes @andreabergia's
original commits and a few more tweaks on top.
Closes #962