fix: Deleting property stripping from product when sent unbundled #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @einsteinx2 @BrandonStalnaker, this is the issue I've told you about in the Dev Tools. Can you take a look at it and let me know if it looks ok? Thx! |
BrandonStalnaker
requested changes
Feb 7, 2024
| @@ -430,7 +430,8 @@ - (void)testlogPurchaseCommerceEvent { | |||
| @"Total Amount" : @13.00, | |||
| @"Total Product Amount" : @"13", | |||
| @"Tax Amount" : @3, | |||
| @"Transaction Id" : @"foo-transaction-id" | |||
There was a problem hiding this comment.
could we add example of all 3 of the keys to this test? Everything else looks great!
BrandonStalnaker
merged commit d0b477b
into
mparticle-integrations:development
3 checks passed
mparticle-automation
added a commit
that referenced
this pull request
Feb 7, 2024
## [8.3.1](v8.3.0...v8.3.1) (2024-02-07) ### Bug Fixes * Deleting property stripping from product when sent unbundled ([#86](#86)) ([d0b477b](d0b477b))
|
🎉 This PR is included in version 8.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
It was tested manually by checking the payloads that braze receives.
This is a sample payload of a product with category without the change:
This is a sample payload with the change:
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)