Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Consent When Kit Is Initialized #98

Conversation

v-lecheverria
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • The updateConsent is now called after the kit is initialized so that the mapping of the consent attributes is done correctly with an active kit.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Set a breakpoint in the mapping of the consent attributes to evaluate the status of the kit (NOT nil)

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@einsteinx2 einsteinx2 self-requested a review October 18, 2024 16:01
@einsteinx2 einsteinx2 merged commit 0d74b3c into mparticle-integrations:development Oct 18, 2024
3 checks passed
mparticle-automation added a commit that referenced this pull request Oct 18, 2024
## [8.10.1](v8.10.0...v8.10.1) (2024-10-18)

### Bug Fixes

* Update consent attributes after kit is initialized ([#98](#98)) ([0d74b3c](0d74b3c))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 8.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants