Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw a beautiful 'You won!' window #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Draw a beautiful 'You won!' window #22

wants to merge 1 commit into from

Conversation

greno4ka
Copy link
Contributor

I make a little improvement of your game. Tested. Looks like this.

Look at it some evening, and merge, if you like it=)

shot-2018-02-13_14-58-21

@mpereira
Copy link
Owner

What do you think about drawing a message on top of the game screen?

@greno4ka
Copy link
Contributor Author

I drawed it in the center of 25x80 screen. You can place it wherever you want!

@mpereira
Copy link
Owner

I meant with the deck still showing below the message, so that the player can still see the game state.

@greno4ka
Copy link
Contributor Author

I think you should just remove content of 103 line in that file=) But this should be done carefully, to save the beauty of the program. I can check, how this idea will look like.

@greno4ka
Copy link
Contributor Author

Without detecting win situation:
_2018-08-13_05-42-33
After detecting win situation:
_2018-08-13_05-48-29

If you want to know my opinion: I think text on clear green window looks better!

@mpereira mpereira force-pushed the master branch 3 times, most recently from c878544 to e08cb0f Compare September 2, 2018 15:20
@greno4ka
Copy link
Contributor Author

So what?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants