Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

code blocks contrast is very low #48

Open
tlhuillier opened this issue Aug 8, 2018 · 1 comment
Open

code blocks contrast is very low #48

tlhuillier opened this issue Aug 8, 2018 · 1 comment
Milestone

Comments

@tlhuillier
Copy link

Hello,

I find that the code blocks are very hard to read, having a very low contrast. It can be quite disturbing especially for documentation with a lot of code examples.

inline code from the Bootstrap example
screen shot 2018-08-08 at 17 51 24

bigger code block, from a project of mine, even harder to read IMO
screen shot 2018-08-08 at 17 55 28


I know we can provide our own CSS rules on a per project basis, but I think default style should promote readability and comfort.

How do you feel about it ?

@mpetrovich
Copy link
Owner

Now that you bring it up, I agree—the default styles should be more accessible. We’re using one of the default highlight.js themes I believe, so it’s just a matter of us replacing that with a more accessible one.

Would be nice to make that theme configurable via config too.

Thanks for raising this issue!

@mpetrovich mpetrovich added this to the 3.x milestone Aug 8, 2018
@mpetrovich mpetrovich removed this from the 3.x milestone Oct 23, 2018
@mpetrovich mpetrovich added this to the v4.0 milestone Dec 30, 2019
@mpetrovich mpetrovich reopened this Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants