Parameter edits should be in a custom parameter route

mrdjohnson · Nov 23, 2024 · a0c979c · a0c979c
1 parent cfc1aa3
commit a0c979c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/src/components/listItem/BaseListItem.tsx b/src/components/listItem/BaseListItem.tsx
@@ -7,6 +7,7 @@ import { NavButtonDiv } from '~/components/NavButton'
 
 export type BaseListItemType<T> = {
   id: string
+  to?: string
   label: string
   data: T
 
@@ -37,7 +38,7 @@ const BaseListItem = observer(
     return (
       <NavButtonDiv
         key={item.id}
-        to={item.id}
+        to={item.to || item.id}
         onClick={e => onClick?.(item, index, e)}
         className={twMerge(
           'rounded-md bg-base-200 p-1 first-of-type:mt-0',

diff --git a/src/containers/SettingSection.tsx b/src/containers/SettingSection.tsx
@@ -10,6 +10,7 @@ import { NavButton } from '~/components/NavButton'
 
 export type SettingSectionItem<T> = {
   id: string
+  to?: string
   label: string
   subLabels?: string | string[]
   data: T

diff --git a/src/features/settings/panels/connections/ConnectionParameterSection.tsx b/src/features/settings/panels/connections/ConnectionParameterSection.tsx
@@ -291,7 +291,7 @@ const ConnectionDataParameterSection = ({ subControl }: { subControl: unknown })
       isJson: false,
     })
 
-    navigate('newField')
+    navigate('parameter/newField')
   }
 
   const removeParameterByIndex = (index: number) => {
@@ -301,7 +301,8 @@ const ConnectionDataParameterSection = ({ subControl }: { subControl: unknown })
   const parameterToSectionItem = (
     parameter: ConnectionParameterModel,
   ): SettingSectionItem<ConnectionParameterModel> => ({
-    id: parameter.field || '',
+    id: parameter.field,
+    to: 'parameter/' + parameter.field,
     label: parameter.field,
     subLabels: parameter.helpText && [parameter.helpText],
     data: parameter,

diff --git a/src/features/settings/settingRoutes.tsx b/src/features/settings/settingRoutes.tsx
@@ -51,7 +51,7 @@ export const settingRoutesByName: Record<SettingPanelOptionsType, SettingPanelTy
         <Route path="empty_panel" element={<NewConnectionPanel />} />
 
         <Route path="edit/:id" element={<ConnectionPanel />}>
-          <Route path=":parameterId" element={<ParameterForm />} />
+          <Route path="parameter/:parameterId" element={<ParameterForm />} />
         </Route>
 
         <Route path=":id" element={<ConnectionModelPanel />}>