-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package.json -> type: "module" -- not supported #231
Comments
its sounding like I should drop commonjs module and just go esm |
Hi, I just wanted to ask if there was an update on this. I would really like to use this package, but I have to use esm. So changing back to cjs is not an option for me. Is there any way to help you with this? |
yes, if you have time to create a PR to fix this that would be awesome |
Ok, I just have to get a release out the next week. When that is done in about 2 weeks, I will make the pull request. I have already forked and implemented it, just have to make it nice and create the pull request. |
awesome thankyou, there will be many people thanking you |
updates? |
Im happy for this project to move to esm only |
Any news about this ? I have same problem on my project I moved to full ESM. This is my
When I launch it in node 20 using
|
Any updates on this? |
I haven't had a chance to look at this I am open to PRs and new maintainers |
I recently needed to add
type:"module"
to mypackage.json
and setup mymodules: "ESNext"
. This has caused joi-to-typescript to break with the following error.Now, if I add this to my tsconfig.json:
and remove
type: "module"
frompackage.json
While I can clearly remove / readd the type module to my package.json, I was wondering if there is a build target fix that would resolve this... e.g. not commonjs module.
Any thoughts?
The text was updated successfully, but these errors were encountered: