Option to use double quotes (") as escape character #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 98.48% 98.52% +0.03%
==========================================
Files 9 9
Lines 661 676 +15
Branches 266 264 -2
==========================================
+ Hits 651 666 +15
Misses 10 10 ☔ View full report in Codecov by Sentry. |
mrjono1
reviewed
Aug 4, 2024
README.md
Outdated
| * If set to true, will use double quotes for strings | ||
| * @default false | ||
| */ | ||
| readonly doublequoteEscape: boolean; |
There was a problem hiding this comment.
Looks great can you remove the word readonly here? I'll get this released for you
There was a problem hiding this comment.
Looks great can you remove the word readonly here? I'll get this released for you
done! thanks!
mrjono1
approved these changes
Aug 5, 2024
|
change released https://github.com/mrjono1/joi-to-typescript/releases/tag/4.14.0 |
|
Thankyou for the contribution |
|
thanks @mrjono1 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team is using double quotes for strings and we have to manually edit generated interfaces to pass our linter. This PR adds
Settings.doublequoteEscapewhich will use double quotes in generated interfaces if set totrue. Default behavior stays unchanged.