Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename getFrameProcessorPlugin to initFrameProcessorPlugin #2038

Merged
merged 9 commits into from
Oct 19, 2023

Conversation

mrousavy
Copy link
Owner

What

cc @mateusz1913

Changes

Tested on

Related issues

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 9:17am

@mateusz1913
Copy link
Contributor

👍 I added it to mateusz1913/vision-camera-plugin-builder#57 and will release it once you bump VisionCamera

@mrousavy
Copy link
Owner Author

@mateusz1913 wdyt of that? #2036 (comment) Maybe we can register the plugins in that static block, probably better since they're not bound to lifecycle anyways.

@mrousavy mrousavy merged commit 07027d8 into main Oct 19, 2023
14 checks passed
@mrousavy mrousavy deleted the fix/rename-to-init branch October 19, 2023 09:19
isaaccolson pushed a commit to isaaccolson/deliveries-mobile that referenced this pull request Oct 30, 2024
…rousavy#2038)

* fix: Rename `getFrameProcessorPlugin` to `initFrameProcessorPlugin`

* fix: Make nullable, add comments

* Format

* Update FrameProcessorPlugin.java

* Update FrameProcessorPlugin.h

* fix: Fix dead links

* Call super constructor

* Update ExampleFrameProcessorPlugin.java

* fix: Init calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants