fixes

mscroggs · Sep 27, 2024 · 05b21eb · 05b21eb
1 parent e855ec3
commit 05b21eb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/symfem/elements/bubble.py b/symfem/elements/bubble.py
@@ -33,12 +33,16 @@ def __init__(self, reference: Reference, order: int, variant: str = "equispaced"
         from symfem import create_element
 
         p1 = create_element(reference.name, "Lagrange", 1, vertices=reference.vertices)
+        basis = p1.get_basis_functions()
         bubble = 1
-        if reference.name in ["interval", "quadrilateral", "hexahedron"]:
-            for v in x[: reference.tdim]:
-                bubble *= v * (1 - v)
+        if reference.name in "quadrilateral":
+            bubble *= basis[0]
+            bubble *= basis[3]
+        if reference.name in "hexahedron":
+            bubble *= basis[0]
+            bubble *= basis[7]
         else:
-            for f in p1.get_basis_functions():
+            for f in basis:
                 bubble *= f
 
         if reference.name in ["interval", "quadrilateral", "hexahedron"]:

diff --git a/symfem/elements/serendipity.py b/symfem/elements/serendipity.py
@@ -89,7 +89,7 @@ def polynomial_superdegree(self) -> typing.Optional[int]:
     min_order = 1
     continuity = "C0"
     value_type = "scalar"
-    last_updated = "2023.06"
+    last_updated = "2024.09"
 
 
 class SerendipityCurl(CiarletElement):