Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arm64: dts: qcom: msm8916-samsung-fortuna/rossa: Upstreaming #273

Closed
wants to merge 15 commits into from
Closed

arm64: dts: qcom: msm8916-samsung-fortuna/rossa: Upstreaming #273

wants to merge 15 commits into from

Conversation

wonderfulShrineMaidenOfParadise
Copy link

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise commented Jan 8, 2023 •
edited
Loading

Discussion thread before upstreaming.

Todo

  • Rename the device trees like downstream does (fortuna-*)
  • Or use the codenames in build.prop
  • Drop Redo samsung,fortuna
  • Squash commits (Sensors, NFC...)
  • Enable NFC for grandprimelte if there is anyone interested
  • Add coreprimeltespr if there is anyone interested
  • Add cprimeltetmo if there is anyone interested
  • Add fortuna3gdtv if there is anyone interested. Cc @TotallyNotChloe
  • Add fortunaltedx if there is anyone interested. Cc @BaranSenkul
  • Add fortunalteub if there is anyone interested. Cc @pachof
Model Current DTS Codename Downstream DTS
SM-G530BT None fortuna3gdtv fortunadtv
SM-G530F None fortunaltedx fortuna-sea
SM-G530FZ grandprimelte grandprimelte fortuna-eur
SM-G530H fortuna3g fortuna(ve)3g fortuna-r11/fortuna-ve3g
SM-G530M None fortunalteub fortuna-r11
SM-G530MU/Y None -> fortunaltezt fortunaltezt fortuna-r11 (another variant)
SM-G530W gprimeltecan gprimeltecan fortuna-tmo
SM-G360G rossa rossaltexsa rossa-eur
SM-G360P None coreprimeltespr rossaspr
SM-G360T None cprimeltetmo rossatmo
SM-G357FZ None -> heatqlte heatqlte heat

Current conclusions

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise marked this pull request as ready for review January 8, 2023 09:46
@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise marked this pull request as ready for review June 20, 2024 12:17
@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the title arm64: dts: qcom: msm8916-samsung-fortuna/rossa: Add initial device trees arm64: dts: qcom: msm8916-samsung-fortuna/rossa: Upstreaming Jul 24, 2024
@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the base branch from wip/msm8916/6.9 to wip/msm8916/6.10 July 26, 2024 19:20
@wonderfulShrineMaidenOfParadise
UPSTREAM: arm64: dts: qcom: msm8916-samsung-rossa: Add touchscreen
9f67236 
Core Prime uses an Imagis IST3038 touchscreen that is connected to
blsp_i2c5. Add it to the device tree.

Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20240723131441.1764-1-raymondhackley@protonmail.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
@wonderfulShrineMaidenOfParadise
UPSTREAM: arm64: dts: qcom: msm8916-samsung-fortuna: Add touch keys
ac1a188 
Touch keys feature on fortuna phones are provided by Zinitix touchscreen.
Add property linux,keycodes to enable touch keys.

Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20240724143230.3804-1-raymondhackley@protonmail.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
@wonderfulShrineMaidenOfParadise
FROMLIST: arm64: dts: qcom: msm8916/8216-samsung-fortuna: Add samsung…
e8d20b0 
…,fortuna binding

Add common binding samsung,fortuna used by the following
Samsung Galaxy Grand Prime devices:
- SM-G530FZ (msm8916-samsung-grandprimelte)
- SM-G530H  (msm8216-samsung-fortuna3g)
- SM-G530W  (msm8916-gprimeltecan)

Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
Link: https://lore.kernel.org/lkml/20240326141222.200452-2-raymondhackley@protonmail.com
@wonderfulShrineMaidenOfParadise
arm64: dts: qcom: msm8916-samsung-fortuna: Add display panel
018ea30 
Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
@wonderfulShrineMaidenOfParadise
arm64: dts: qcom: msm8916-samsung-rossa: Add display panel
24e3948 
Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
@buddyjojo @wonderfulShrineMaidenOfParadise
FIXME: arm64: dts: qcom: msm8916-samsung-fortuna: Add audio jack dete…
a67c078 
…ction

Signed-off-by: Joe Mason <buddyjojo06@outlook.com>
[Raymond: Split from the audio patch]
Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
@bolilingmeng89006 @wonderfulShrineMaidenOfParadise
arm64: dts: qcom: msm8916-samsung-fortunaltezt: Add initial device tree
fc671c0 
Samsung Galaxy Grand Prime (SM-G530Y) is a smartphone using the MSM8916
SoC released in 2014.

The Grand Prime variants are very similar, with some differences in
accelerometer and NFC. The common parts are shared in
msm8916-samsung-fortuna-common.dtsi to reduce duplication.

Unfortunately, SM-G530Y was released with outdated 32-bit only
firmware and never received any update from Samsung. Since the 32-bit
TrustZone firmware is signed there seems to be no way currently to
actually boot this device tree on arm64 Linux at the moment.

However, it is possible to use this device tree by compiling an ARM32
kernel instead. The device tree can be easily built on ARM32 with
an #include and it works really well there. To avoid confusion for others
it is still better to add this device tree on arm64. Otherwise it's easy
to forget to update this one when making some changes that affect all
MSM8916 devices.

Maybe someone finds a way to boot ARM64 Linux on this device at some
point.
In this case we expect that this device tree can be simply used as-is.

Signed-off-by: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
@garethppls @wonderfulShrineMaidenOfParadise
arm64: dts: qcom: msm8916-samsung-heatqlte: Add initial device tree
f6e8e7f 
Samsung Galaxy Ace 4 is a phone based on MSM8916. It is similar
to the other Samsung devices based on MSM8916 with only a few minor
differences.

Ace 4 and Core Prime are similar, with some differences in panel and
touchscreen. The common parts are shared in
msm8916-samsung-rossa-common.dtsi to reduce duplication.

Unfortunately, SM-G357FZ was released with outdated 32-bit only
firmware and never received any update from Samsung. Since the 32-bit
TrustZone firmware is signed there seems to be no way currently to
actually boot this device tree on arm64 Linux at the moment.

However, it is possible to use this device tree by compiling an ARM32
kernel instead. The device tree can be easily built on ARM32 with
an #include and it works really well there. To avoid confusion for others
it is still better to add this device tree on arm64. Otherwise it's easy
to forget to update this one when making some changes that affect all
MSM8916 devices.

Maybe someone finds a way to boot ARM64 Linux on this device at some
point.
In this case we expect that this device tree can be simply used as-is.

Signed-off-by: Gareth Peoples <mail@gpeopl.es>
[Raymond: Use msm8916-samsung-rossa-common.dtsi and reword the commit]
Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
@bolilingmeng89006 @wonderfulShrineMaidenOfParadise
ARM: dts: qcom-msm8916-samsung-fortunaltezt/heatqlte: Include dts fro…
d00fe7b 
…m arm64

After adding all necessary support for MSM8916 SMP/cpuidle without PSCI
on ARM32, build fortunaltezt and heatqlte device trees from the arm64
tree together with the ARM32 include to allow booting this device on ARM32.

The approach to include device tree files from other architectures is
inspired from e.g. the Raspberry Pi (bcm2711-rpi-4-b.dts) where this is
used to build the device tree for both ARM32 and ARM64.

[Stephan: Add workaround to TSENS problem]
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
[Gareth: Add heatqlte]
Signed-off-by: Gareth Peoples <mail@gpeopl.es>
Signed-off-by: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
@bolilingmeng89006 @wonderfulShrineMaidenOfParadise
ARM: dts: qcom-msm8916-samsung-fortunaltezt/heatqlte: Add qcom,srot-l…
d2d7ced 
…ocked to workaround TSENS problem

Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: Gareth Peoples <mail@gpeopl.es>
Signed-off-by: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
@wonderfulShrineMaidenOfParadise
arm64: dts: qcom: msm8916-samsung-fortunaltezt/heatqlte: Add PMIC
088b419 
The phones listed below have Richtek RT5033 PMIC and charger.
Add them to the device trees.
- Samsung Galaxy Ace 4 (SM-G357FZ)
- Samsung Galaxy Grand Prime (SM-G530Y)

Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
@bolilingmeng89006 @wonderfulShrineMaidenOfParadise
arm64: dts: qcom: msm8916-samsung-fortunaltezt: Add accelerometer
1b6c333 
This device has ST LIS2HH12 accelerometer.
Add support for it.

Signed-off-by: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
@bolilingmeng89006 @wonderfulShrineMaidenOfParadise
arm64: dts: qcom: msm8916-samsung-fortuna: Add PN547 NFC (v3)
b269ee1 
Grand Prime SM-G530Y (fortunaltezt) has a NXP PN547, which is supported
by the nxp-nci-i2c driver in mainline. It seems to detect NFC tags
using "nfctool" just fine, although more testing is difficult given
there seem to be very few useful applications making use of the
Linux NFC subsystem. :(

[Stephan: Move i2c-nfc to common dtsi to share it with other variants]
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
v2: Reword and add label pn547_nfc
v3: Use interrupts-extended
Signed-off-by: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
@bolilingmeng89006 @wonderfulShrineMaidenOfParadise
arm64: dts: qcom: msm8916-samsung-fortunaltezt: Add display panel
b443662 
Signed-off-by: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
@garethppls @wonderfulShrineMaidenOfParadise
arm64: dts: qcom: msm8916-samsung-heatqlte: Add display panel
5e4fbff 
Signed-off-by: Gareth Peoples <mail@gpeopl.es>
[Raymond: Split from the init commit]
Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jakko3 Jakko3 Jakko3 left review comments

@stephan-gh stephan-gh stephan-gh left review comments

Assignees
No one assigned
Labels
upstreaming
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wonderfulShrineMaidenOfParadise @cristianc @stephan-gh @pachof @Jakko3 @buddyjojo @bolilingmeng89006 @garethppls