Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.0.0 #67

Merged
merged 18 commits into from
Jan 10, 2024
Merged

v4.0.0 #67

merged 18 commits into from
Jan 10, 2024

Conversation

BryanSoltis
Copy link
Contributor

IMPORTANT NOTES

With the release of v4.0.0, the Azure Naming Tool has been upgraded to a .NET 8 Blazor Web App. This requires an update to the hosting environment, as well as a BACKUP & RESTORE of your configuration. Review the v4.0.0 Migration Guide for details.

View the Azure Naming Tool v4.0.0 Migration Guide

FEATURES

  • Updated project to .NET 8
  • Updated project to Blazor Web App
  • Added new site setting for enabling/disabling Instructions page for non-admin users
  • Added new site setting for enabling/disabling Generated Names Log page for non-admin users
  • Added new site settings for enabling/disabling Latest News for all users
  • Added site setting reset functionality to Admin page
  • Updated locations to include new regions / align naming conventions across all Microsoft Azure Clouds

BUG FIXES

CONTRIBUTORS

Update dev branch with latest changes
Update versionalerts.json
With the release of v4.0.0, the Azure Naming Tool has been upgraded to a .NET 8 Blazor Web App. This requires an update to the hosting environment, as well as a BACKUP & RESTORE of your configuration. Review the v3.4.0 Migration Guide for details.

[View the Azure Naming Tool v3.4 Migration Guide](https://github.com/mspnp/AzureNamingTool/wiki/v3.4.0-MigrationGuide)

### FEATURES
- Updated project to .NET 8
- Updated project to Blazor Web App
- Added new site setting for enabling/disabling Instructions page for non-admin users
- Added new site setting for enabling/disabling Generated Names Log page for non-admin users
- Added new site settings for enabling/disabling Latest News for all users

### CONTRIBUTORS
- [mwiedemeyer](https://github.com/mwiedemeyer)
With the release of v4.0.0, the Azure Naming Tool has been upgraded to a .NET 8 Blazor Web App. This requires an update to the hosting environment, as well as a BACKUP & RESTORE of your configuration. Review the v3.4.0 Migration Guide for details.

[View the Azure Naming Tool v3.4 Migration Guide](https://github.com/mspnp/AzureNamingTool/wiki/v3.4.0-MigrationGuide)

### FEATURES
- Updated project to .NET 8
- Updated project to Blazor Web App
- Added new site setting for enabling/disabling Instructions page for non-admin users
- Added new site setting for enabling/disabling Generated Names Log page for non-admin users
- Added new site settings for enabling/disabling Latest News for all users

### CONTRIBUTORS
- [mwiedemeyer](https://github.com/mwiedemeyer)
### BUG FIXES
- Fixed #64 - Updated auto-increment process to properly set instance/number of digits
@BryanSoltis BryanSoltis merged commit 7f35866 into main Jan 10, 2024
3 checks passed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locations are perfect!

@BryanSoltis BryanSoltis mentioned this pull request Jan 10, 2024
@psilantropy
Copy link

psilantropy commented Feb 2, 2024

Hello :). Regarding some locations;

    "id": 3,
    "name": "Australia East",
    "shortName": "ae"
    "shortName": "aue"
  },
  {
    "id": 4,
    "name": "Australia Southeast",
    "shortName": "as"
    "shortName": "aus"

What's the source on these? As I understood them:

Australia East
australiaeast, ae, aeu, ea

Australia Southeast
australiasoutheast, ase, seau, sau

We use ae and ase which aren't present in the tool any longer by default.

@jamasten
Copy link
Contributor

jamasten commented Feb 2, 2024

@psilantropy we updated the locations based on feedback. Locations for AzureCloud have a two character region code (continent / country) based on ISO 3166, a 1 or 2 character direction, and a digit if applicable. "au" is for Australia. "e" is for east. "se" is for southeast. The Azure Naming Tool uses APIs making it agnostic. I do not use terraform and have no affiliation with the team managing the tool you referenced. You can restore the locations if you do not like the update.

@psilantropy
Copy link

Thanks @jamasten. I just posted the URL as an example; I don't use terraform currently.

I'm more than happy to adjust the configuration to suit our environment, I just hoped to find a reference with MS/AzureCloud that aligns with what we have here - and I couldn't. Then I couldn't see anything in the changes to show what we're moving from-to. I am looking at adjusting our location naming for our business and hoped to find references.

What I thought the tool was using (geocode, ae/ase) - https://learn.microsoft.com/en-us/azure/backup/scripts/geo-code-list

The main issue for us with the new short names is they are longer. :) Plus Australia East is now East Asia ;) - not that we use more than 2-5 regions here anyway.

I did find another terraform option recently updated that matches this change: https://github.com/claranet/terraform-azurerm-regions/blob/master/REGIONS.md
But their reference is also to a link without this data.

Don't get me wrong - these new short names are much easier to understand at a glance.

@jamasten
Copy link
Contributor

jamasten commented Feb 3, 2024

@psilantropy CAF guidance and the Azure Naming Tool provide a framework for naming. Both allow for flexibility but make recommendations to simplify the process and avoid naming collisions. We make every effort for a customer to customize the tool to their liking. The defaults are simply that. No need to keep them if you don't them. This wasn't an arbitrary update but instead fueled by feedback. I recently stumbled upon the geocodes list myself when enabling private endpoints on recovery services vaults. It was very similar to the Naming Tool's old list but not 100%. Still, we believe the new list makes sense for most customers since it aligns to the ISO standard that most people are familiar with. That's interesting you found another repo with a similar list as our new locations. The new short names are only longer by one character so if you're constrained on a resource, you may way to shorten another component by one character or remove the delimiter for that resource.

@psilantropy
Copy link

Cool. Thanks for the explanation and your time @jamasten

Character count saving for us is mainly for VMs. We have something in place (combining env and loc) which helps with character reduction, but I was researching options that are more widely used and understood.

Keep up the good work :)

@psilantropy
Copy link

Sorry to drag this thread up again;

ISO 3166, a 1 or 2 character direction, and a digit if applicable. "au" is for Australia. "e" is for east. "se" is for southeast

ISO3166 for au, and then e(aue) and s(aus) was created by the aznamingtool dev team? Just looking to reference ISO3166 in my documentation :).

@jamasten
Copy link
Contributor

@psilantropy to be specific, we are using the alpha-2 codes in the ISO 3166 standard for the countries. The location portion is abbreviated using the first letter in each word.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource instance autoincrement feature does not adhere to minimum length requirement of field
3 participants