Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to add note about handler inheritance #158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md to add note about handler inheritance #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ type MswParameter = {
}
```

_**Note:** Handler inheritance only works when the root `handlers` is an object; arrays of handlers will not be merged._
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yannbf, this is something we need to reconsider. What is the argument against merging array handlers? I'd expect Storybook to use .unshift() and be done with this.


Suppose you have an application where almost every component needs to mock requests to `/login` and `/logout` the same way.
You can set global MSW handlers in preview.js for those requests and bundle them into a property called `auth`, for example:

Expand Down