vim: only link to the perl DLL _dynamically_ #4058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The major Perl version is encoded in the file name of the Perl DLL, which makes it much more desirable to link _dynamically_ to the DLL, i.e. on demand. Otherwise `vim.exe` would not even start unless Perl is installed, at the exact expected version. However, due to a bug, even `--enable-perlinterop=dynamic` would let `vim.exe` link to the Perl DLL, defeating the purpose of the `dynamic` part. This was fixed in the VIM project, via vim/vim@55460da26c27, and here is a backport to get this fix into MSYS2. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
changed the title
|
thanks. fyi, our vim is a bit outdated right now since newer versions fail to build for a few months, and I wasn't motivated enough to look into it. |
I noticed, and will have a quick look at it now. In the meantime, maybe we can go with this PR, as a band-aid until we get current VIM versions to build again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major Perl version is encoded in the file name of the Perl DLL, which makes it much more desirable to link dynamically to the DLL, i.e. on demand. Otherwise
vim.exewould not even start unless Perl is installed, and the exact expected version at that.However, due to a bug, even
--enable-perlinterop=dynamicwould letvim.exelink to the Perl DLL, defeating the purpose of thedynamicpart.This was fixed in the VIM project, via vim/vim@55460da26c27, and here is a backport to get this fix into MSYS2.
This PR addresses git-for-windows#115 (comment).