Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get test coverage of OCaml+Rust code #2

Open
mt-caret opened this issue Jun 17, 2023 · 1 comment · May be fixed by #74
Open

Get test coverage of OCaml+Rust code #2

mt-caret opened this issue Jun 17, 2023 · 1 comment · May be fixed by #74
Labels

Comments

@mt-caret
Copy link
Owner

The only sources of SEGV issues so far were:

  • polars bugs
  • mis-specifying types on the OCaml side in externs

The second case is a bit scary, and I think a naive code coverage metric to ensure that all functions we expose are tested would ensure that we don't get surprised by anything like this. A lesser worry is if we, for example, say that an argument is an int option instead of an bool option I don't think we'll get a SEGV as long as we just pass a None, since the OCaml memory representation is identical. Perhaps OCaml tests -> Rust-side code coverage would solve this, though I'm not sure whether code-coverage tools support this kind of thing.

@mt-caret mt-caret mentioned this issue Aug 4, 2023
@mt-caret
Copy link
Owner Author

mt-caret commented Aug 7, 2023

I'm looking into using kcov for doing this.

@mt-caret mt-caret linked a pull request Sep 17, 2023 that will close this issue
@mt-caret mt-caret added the ci label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant