Fix non-existing atom exception when accidentally matching on map literal #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eral
This fixes a crash that looks like this:
```
** (ArgumentError) errors were found at the given arguments:
* 1st argument: not an already existing atom
```
...which was previously occurring when you used the literal map matcher on a map with arbitrary string keys that don't have a corresponding atom defined. For me, this occurred when I forgot to wrap my map matcher in a `superset/1`. So, for instance, what I *meant* was:
```elixir
assert %{"foo" => "bar", "baz" => "bop"} ~> superset(%{"foo" => "bar"})
```
...but what I accidentally wrote was just:
```elixir
assert %{"foo" => "bar", "baz" => "bop"} ~> %{"foo" => "bar"}
```
Because the error was so generic, this was pretty difficult to debug. With this change applied, though, you now get a nice "Unexpected key" error.
s3cur3
commented
Dec 9, 2024
Comment on lines
-46
to
+45
| |> MapSet.difference(atom_keys |> Enum.map(&Kernel.to_string/1) |> MapSet.new()) | ||
| |> MapSet.difference(string_keys |> Enum.map(&String.to_existing_atom/1) |> MapSet.new()) | ||
| |> MapSet.difference(MapSet.new(atom_keys, &Kernel.to_string/1)) | ||
| |> MapSet.difference(MapSet.new(string_keys, &safe_existing_atom/1)) |
There was a problem hiding this comment.
The diff on the first line here is not strictly necessary for the fix, but I figured I'd save an unnecessary list creation where possible.
mtrudel
approved these changes
Dec 9, 2024
|
Love it! Thanks for the contribution! |
|
Published as 0.3.6 |
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mat! Thanks so much for this wonderful library. I'm on workplace number 3 where it's been introduced to the delight of my coworkers.☺️
This PR fixes a crash that looks like this:
...which was previously occurring when you used the literal map matcher on a map with arbitrary string keys that don't have a corresponding atom defined. For me, this occurred when I forgot to wrap my map matcher in a
superset/1. So, for instance, what I meant was:...but what I accidentally wrote was just:
Because the error was so generic, this was pretty difficult to debug. With this change applied, though, you now get a nice "Unexpected key" error.